[skip changelog] Remove redundant artifact upload from test workflow #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were two steps in the test workflow for the Linux ARM64 artifact upload. Although it did no real harm since it simply replaced the artifact from the first upload with a duplicate, it does slow down the workflow and adds a little more of a maintenance burden, so better to remove it.
per1234
changed the title
umbynos
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Bug fix
There are two steps in the test workflow for the Linux ARM64 artifact upload:
arduino-cli/.github/workflows/test.yaml
Line 179 in 5115d44
arduino-cli/.github/workflows/test.yaml
Line 185 in 5115d44
Although it does no real harm since it simply replaces the artifact from the first upload with a duplicate, it does slow down the workflow and makes the workflow slightly more difficult to maintain.
There is only a single upload of the Linux ARM64 artifact.
titled accordingly?
No break.